Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require non-empty strings for test description #1981

Merged
merged 4 commits into from
Oct 29, 2024
Merged

require non-empty strings for test description #1981

merged 4 commits into from
Oct 29, 2024

Conversation

kevinushey
Copy link
Collaborator

Closes #1980.

@kevinushey kevinushey requested a review from hadley August 23, 2024 18:34
@hadley
Copy link
Member

hadley commented Oct 22, 2024

Let's start this with a warning.

@hadley hadley added this to the v3.2.2 milestone Oct 22, 2024
@hadley
Copy link
Member

hadley commented Oct 29, 2024

Oooh, it's just for expect_snapshot(). I think it's fine to remain an error then.

@hadley hadley merged commit 3628792 into main Oct 29, 2024
11 checks passed
@hadley hadley deleted the bugfix/testthat-empty-desc branch October 29, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadley hadley Awaiting requested review from hadley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2.2
Development

Successfully merging this pull request may close these issues.

disallow empty strings for test names
2 participants
@kevinushey @hadley